-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lint] Improve clang-tidy and clang-format scripts running in lint #19175
Conversation
This partially rolls forward commit 5d9e3a0, except changes to scripts/format.h
The rllib failure is unrelated. It is fixed by bbc64a7. |
@mwtian Does it make sense to separate it into two PRs to make it easier to get in? I.e. one just changing linter rules another change the the ci/travis/check-git-clang-format-output.sh ? |
Sure, broke out |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
This partially rolls forward commit 5d9e3a0, except changes to
scripts/format.h
Why are these changes needed?
clang-tidy
modernize-use-nodiscard
which is too pedantic.These changes do not affect
scripts/format.sh
. These scripts currently only run during thelint
step of the CI.Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.